Android layout fixes #3695
Merged
Android layout fixes #3695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beerosagos
force-pushed
the
android-layout
branch
from
05f3672 to
ac3d716
Compare
Collaborator
Author
|
Tested on Android 7,8,13,15,16 |
benma
approved these changes
Dec 1, 2025
Contributor
benma
left a comment
benma
left a comment
There was a problem hiding this comment.
tACK on Android 16, very nice!
left two comments
Contributor
There was a problem hiding this comment.
why in the v23 folder (we support v24+ only anyway)? Couldn't it simply be in res/values/styles.xml?
Collaborator
Author
There was a problem hiding this comment.
It's v23 because some of the attributes are supported from v23+. But yeah, since our minSdk is 24 we could also collapse everything inside values/values-night folders.
| - Sort backups from newest to oldest in manage backups | ||
| - Android: fix display of external links from Bitrefill | ||
| - fix language sometimes not persistent across app restarts | ||
| - Android: fix layout issues with status and navigation bars. |
Collaborator
Author
There was a problem hiding this comment.
There were issues also in previous versions
Beerosagos
force-pushed
the
android-layout
branch
from
ac3d716 to
3070d18
Compare
Android 15 (API 35) enforces edge-to-edge display by default, causing the app to draw behind the system navigation bar. This commit adds to the root layout to prevent the app content from overlapping with the system navigation bar.
The colors of both the status and the navigation bars and their icons were not always matching the app background. Also, forcing the app theme in the settings and then switching the OS theme was sometime causing the bar icons to change and blend with the bars. This commit does the following: - Drives the colors of both bars and icons in the setDarkTheme method to avoid misalignemnts with the app theme - Removes the onConfigurationChanged overriding, which was conficting with the implemented theme handling, which is delegated to the frontend DarkmodeProvider. Listening of OS theme changes in the activity must be avoided as it could fire unwanted changes in the app theme. - Improve the app static styles, to reduce the color flickering before setDarkTheme() is called for the first time. - Apply matching backgrounds to the root layout and WebView so the bars blend with the app in both light and dark modes.
Beerosagos
force-pushed
the
android-layout
branch
from
3070d18 to
0886330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The colors of both the status and the navigation bars and their icons
were not always matching the app background.
Also, forcing the app theme in the settings and then switching the OS
theme was sometime causing the bar icons to change and blend with the
bars.
This commit does the following:
to avoid misalignemnts with the app theme
with the implemented theme handling, which is delegated to the frontend
DarkmodeProvider. Listening of OS theme changes in the activity must be
avoided as it could fire unwanted changes in the app theme.
setDarkTheme() is called for the first time.
blend with the app in both light and dark modes.
Also fixes navigation bar overlap.